fabric8-services / fabric8-wit

wit stands for Work Item Tracker
http://devdoc.almighty.io/
Apache License 2.0
45 stars 86 forks source link

Revert "Add support for system_* fields along with system.* fields #2401

Closed jarifibrahim closed 5 years ago

jarifibrahim commented 5 years ago

Revert "Add support for system_ fields along with system. fields (#2341)" This reverts commit 587d0d29ce0d13e9c2c0edc3ef1816e8debb121a.

2341 was merged but the core-97 deployment was failing. This PR reverts the changes.

A possible reason for the deployment failure could be the huge database migration. The field rename PR updates every row of 3 tables. This is a database intensive operation and would take some amount of time to complete. But since it didn't complete within the timeout, openshift marks the pod as unhealthy and kills it. A new pod would come up and the same cycle would repeat.

Kibana logs - https://logs.dsaas-stg.openshift.com/app/kibana#/discover?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:'2019-01-22T12:50:00.000Z',mode:absolute,to:'2019-01-22T13:20:00.000Z'))&_a=(columns:!(_source),filters:!(),index:'project.dsaas-preview.6e520a9f-d097-11e8-9fb7-121499db9246.*',interval:auto,query:(query_string:(analyze_wildcard:!t,query:'kubernetes.labels.deployment:core-97')),sort:!('@timestamp',desc))

This shows the Kibana logs for the actual pod: kubernetes.pod_name:"core-97-6cjh9" AND kubernetes.namespace_name:"dsaas-preview"&_a=(columns:!(kubernetes.container_name,message),index:'project.dsaas-preview.6e520a9f-d097-11e8-9fb7-121499db9246.*',interval:auto,query:(query_string:(analyze_wildcard:!t,query:'kubernetes.pod_name:%22core-97-6cjh9%22+AND+kubernetes.namespace_name:%22dsaas-preview%22')),sort:!('@timestamp',desc)))

codecov[bot] commented 5 years ago

Codecov Report

Merging #2401 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2401   +/-   ##
=======================================
  Coverage   67.79%   67.79%           
=======================================
  Files         183      183           
  Lines       18145    18145           
=======================================
  Hits        12302    12302           
  Misses       4661     4661           
  Partials     1182     1182

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 587d0d2...8b190fc. Read the comment docs.

sbose78 commented 5 years ago

Given that the 'rename' story touches a vast number of records in the database ( probably needs SD assistance to get the deployment work), and the impact is primarily adherence to the spec, I would suggest we drop the story for now as the effort gives us little RoI.