search

fabric8-services / fabric8-wit

wit stands for Work Item Tracker
http://devdoc.almighty.io/
Apache License 2.0
45 stars 86 forks source link

Proxy /logout/v2 to Auth service #2403

Closed alexeykazakov closed 5 years ago

alexeykazakov commented 5 years ago

Related to https://github.com/openshiftio/openshift.io/issues/4757

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @alexeykazakov for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin.

alexeykazakov commented 5 years ago

Adding proper and meaningful testing for that endpoint could be tricky since it just proxy it to Auth.

sbose78 commented 5 years ago

Change looks fine to me, pretty straightforward .

sbose78 commented 5 years ago

/ok-without-tests

alexeykazakov commented 5 years ago

[test]