Closed divyanshiGupta closed 5 years ago
Thank you @divyanshiGupta for this contribution!
It seems that this PR already contains some added or changed tests. Good job!
Your plugin configuration is stored in the file.
@divyanshiGupta are you still working on this? please rebase
@divyanshiGupta can you please rebase this and get it to a state that it can be merged?
@joshuawilson this is not complete and we decided in the planning we will not be doing this task as the SDD template is going away anyway. So closing this PR.
Note: If there are pending changes to the PR, prefix the PR title with "WIP" and add the label "DO NOT MERGE"
Mandatory
[ ] What does this PR do?
This PR implements closing of quick-preview, if open, if user switches between or clicks on any group-type.
If there are any unsaved workitem changes in the quick-preview it will ask the user to save the changes if they want to.
Blockers:
Currently we have close on outside-click on most of the fields in quick-preview so when any of these fields have unsaved changes and then save button is clicked on the modal the fields gets closed because of outside-click functionality.
[ ] What issue/task does this PR references? Fixes https://github.com/openshiftio/openshift.io/issues/2598
[ ] Are the tests Included? WIP
Optional
[ ] Is the documentation Included?
[ ] Are the Release Notes included?
[ ] @mention(s) to expected reviewer(s) included