search

fabric8-ui / fabric8-planner

https://fabric8-ui.github.io/fabric8-planner/
Apache License 2.0
26 stars 62 forks source link

fix(builds): Add unsafe-perm flag to npm install #2788

Closed jarifibrahim closed 6 years ago

jarifibrahim commented 6 years ago

fabric8-ui contains a postinstall.sh script which will not work inside a container that is running with super user privileges. The postinstall script in fabric8-ui fails with

npm WARN lifecycle fabric8-ui@0.0.0-development~postinstall: cannot run in wd %s %s (wd=%s) fabric8-ui@0.0.0-development ./post-install.sh /home/fabric8/fabric8-planner/fabric8-ui

on cico (docker container).

Example failure: https://ci.centos.org/view/Devtools/job/devtools-fabric8-planner-f8planner/2065/consoleFull

https://github.com/fabric8-ui/fabric8-ui/pull/3283/ updated fabric8-ui and caused all builds on fabric8-planner to fail.

More information on https://stackoverflow.com/questions/18136746/npm-install-failed-with-cannot-run-in-wd

Also Fixes the Sev-1: https://github.com/openshiftio/openshift.io/issues/4309

alien-ike commented 6 years ago

Ike Plugins (test-keeper)

Thank you @jarifibrahim for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

Your plugin configuration is stored in the file.

centos-ci commented 6 years ago

@jarifibrahim Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2788 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2788 and visit http://localhost:5000 to access it.