search

fabric8-ui / fabric8-planner

https://fabric8-ui.github.io/fabric8-planner/
Apache License 2.0
26 stars 62 forks source link

feat(query): create new work item dialog #2791

Closed sahil143 closed 5 years ago

sahil143 commented 6 years ago

Note: If there are pending changes to the PR, prefix the PR title with "WIP" and add the label "DO NOT MERGE"

Mandatory

alien-ike commented 6 years ago

Ike Plugins (test-keeper)

Thank you @sahil143 for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

Your plugin configuration is stored in the file.

divyanshiGupta commented 6 years ago

@sahil143 this PR has lint errors, please resolve them. And is the PR ready for review or is it work-in-progress?

divyanshiGupta commented 6 years ago

@sahil143 functional tests are failing.

sahil143 commented 6 years ago

@sahil143 functional tests are failing.

Yes @divyanshiGupta I'm working on them

sahil143 commented 6 years ago

[test]

centos-ci commented 6 years ago

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 and visit http://localhost:5000 to access it.

centos-ci commented 6 years ago

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 and visit http://localhost:5000 to access it.

centos-ci commented 6 years ago

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 and visit http://localhost:5000 to access it.

sahil143 commented 5 years ago

[test]

sahil143 commented 5 years ago

[test]

Raunak1203 commented 5 years ago

[test]

centos-ci commented 5 years ago

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 and visit http://localhost:5000 to access it.

centos-ci commented 5 years ago

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 and visit http://localhost:5000 to access it.

centos-ci commented 5 years ago

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 and visit http://localhost:5000 to access it.

divyanshiGupta commented 5 years ago

@sahil143 I have added a few review comments here and there apart from that the code looks good to me. And please make sure to remove console logs before merging this to master.

sahil143 commented 5 years ago

@Raunak1203

If a newly created work item is not matching the query, Can we display some notification saying that "Work Item is created but It doesn't match the Query"

Newly created workitem is not shown at all in the list. we only show a notification.

Create and CreateAndOpen button is disabled after creating 1 workitem

This is fixed in commit https://github.com/fabric8-ui/fabric8-planner/pull/2791/commits/13efa602aba94ec9b38b8420c2122b8c84763cec

After clicking create button creating a workitem dropdown should close.

No, It should not be because user might want to add another workitem right after a workitem is created

centos-ci commented 5 years ago

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 and visit http://localhost:5000 to access it.

centos-ci commented 5 years ago

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2791 and visit http://localhost:5000 to access it.

sudsen commented 5 years ago

/ok-without-tests