search

fabric8-ui / fabric8-planner

https://fabric8-ui.github.io/fabric8-planner/
Apache License 2.0
26 stars 62 forks source link

Query Builder #2806

Closed sahil143 closed 5 years ago

sahil143 commented 5 years ago

Smart Query Builder Story: https://openshift.io/openshiftio/Openshift_io/plan/detail/383

sahil143 commented 5 years ago

[test]

Raunak1203 commented 5 years ago

[test]

christianvogt commented 5 years ago

@sahil143 is this ready for review or are there still changes being made?

sanbornsen commented 5 years ago

@christianvogt this is ready for review. The tests are failing though.

sanbornsen commented 5 years ago

[test]

sahil143 commented 5 years ago

[test]

sahil143 commented 5 years ago

[test]

centos-ci commented 5 years ago

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2806 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2806 and visit http://localhost:5000 to access it.

christianvogt commented 5 years ago

@sahil143 I get this error whenever the query is incorrect. It's very intrusive. An error message below the input would probably be better. image

That being said, when the query is correct it seems to work as expected. There's also some oddities with the content assist when the cursor isn't at the end of the input.

christianvogt commented 5 years ago

When I press enter and the query completes, focus is lost from the input. I would expect focus to remain in the query input field.

christianvogt commented 5 years ago

Sometimes pressing enter executes the query and sometimes it performs an auto complete. It's confusing and often messes up the query. Worst part is that after the query gets messed up I cannot simply press cmd+z to undo, because it doesn't undo the auto complete entry.

christianvogt commented 5 years ago

Got the following error when clicking on a query item to go to the details and then pressing the back button:

ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: 'ngIf: false'. Current value: 'ngIf: true'.

View_PlannerQueryComponent_0 | @ | PlannerQueryComponent.html:22
sahil143 commented 5 years ago

Got the following error when clicking on a query item to go to the details and then pressing the back button: ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: 'ngIf: false'. Current value: 'ngIf: true'. View_PlannerQueryComponent_0 | @ | PlannerQueryComponent.html:22

Fixed in latest commit

Sometimes pressing enter executes the query and sometimes it performs an auto complete

When suggestion dropdown is open pressing enter auto completes the query and when dropdown is close pressing enter executes the query

Worst part is that after the query gets messed up I cannot simply press cmd+z to undo, because it doesn't undo the auto complete entry.

Solution for this would be to keep our own history(ctrl z) for query input field?

When I press enter and the query completes, focus is lost from the input. I would expect focus to remain in the query input field.

This is intended behaviour but I dont see why we can't focus on input after pressing enter. Fixed in latest commit

I get this error whenever the query is incorrect. It's very intrusive. An error message below the input would probably be better.

We dont have query validator which can validate the query. We send the api request for invalid queries and when backend throws error we show this notification error. Also, Area below input has other text. Adding error below input field would disrupt the experience. WDYT?

@christianvogt ^^

centos-ci commented 5 years ago

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2806 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2806 and visit http://localhost:5000 to access it.

joshuawilson commented 5 years ago

@christianvogt is this ready to be merged?

christianvogt commented 5 years ago

@sahil143 there's something wrong w/ the auto complete and the enter key. After entering in the value, pressing enter again replaced my value with the field again. I would expect the query to be issued at this point when pressing enter. query-enter

centos-ci commented 5 years ago

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2806 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2806 and visit http://localhost:5000 to access it.

centos-ci commented 5 years ago

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2806 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2806 and visit http://localhost:5000 to access it.

centos-ci commented 5 years ago

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2806 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2806 and visit http://localhost:5000 to access it.

centos-ci commented 5 years ago

@sahil143 Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2806 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2806 and visit http://localhost:5000 to access it.