search

fabric8-ui / fabric8-planner

https://fabric8-ui.github.io/fabric8-planner/
Apache License 2.0
26 stars 62 forks source link

fix(whitespace-issue): add validation to create label field #2811

Closed karthikjeeyar closed 5 years ago

karthikjeeyar commented 5 years ago

This PR contains the following changes

1. Validates the create label input field, if validation fails disables the create button.
2. Does not allow white space characters at the beginning of the label name.

What issue/task does this PR references?

https://github.com/openshiftio/openshift.io/issues/3117

Test cases - Added

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @karthikjeeyar for this contribution!

It seems that this PR already contains some added or changed tests. Good job!

Your plugin configuration is stored in the file.

joshuawilson commented 5 years ago

[test]

joshuawilson commented 5 years ago

looks like you have a failing test should disable the create label button failed

centos-ci commented 5 years ago

@karthikjeeyar Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2811 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2811 and visit http://localhost:5000 to access it.

centos-ci commented 5 years ago

@karthikjeeyar Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2811 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2811 and visit http://localhost:5000 to access it.

centos-ci commented 5 years ago

@karthikjeeyar Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2811 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2811 and visit http://localhost:5000 to access it.