fabric8-ui / fabric8-planner

https://fabric8-ui.github.io/fabric8-planner/
Apache License 2.0
26 stars 62 forks source link

fix(table-config): Tooltip not displaying in attributes table #2818

Closed abhinandan13jan closed 5 years ago

abhinandan13jan commented 5 years ago

Note: If there are pending changes to the PR, prefix the PR title with "WIP" and add the label "DO NOT MERGE"

Mandatory

Optional

alien-ike commented 5 years ago

Ike Plugins (test-keeper)

Thank you @abhinandan13jan for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

Your plugin configuration is stored in the file.

joshuawilson commented 5 years ago

please add a reference to the issue, either as a 'ref' or as fixes #theNumberOfTheIssue

abhinandan13jan commented 5 years ago

@joshua Added reference

abhinandan13jan commented 5 years ago

@sahil143 Can you check if the PR looks ok? Without the tooltip in place I am not able to work on fixing this issue https://github.com/openshiftio/openshift.io/issues/3856

joshuawilson commented 5 years ago

[test]

abhinandan13jan commented 5 years ago

@joshuawilson No testcases as only metadata of the code has changed

centos-ci commented 5 years ago

@abhinandan13jan Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2818 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2818 and visit http://localhost:5000 to access it.

centos-ci commented 5 years ago

@abhinandan13jan Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2818 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2818 and visit http://localhost:5000 to access it.