fix(table-config): Set arrows as disabled when no column is selected

abhinandan13jan commented 5 years ago

Mandatory

[x] What does this PR do? Sets arrows in attribute settings as disabled when no attribute is selected in table-config component.
- [x] What issue/task does this PR references? This PR addresses the following settings issue https://github.com/openshiftio/openshift.io/issues/3856
- [x] Are the tests Included? Yes, testcases have been included.
  
  Please note: This PR will work properly after the tooltip is in place ( https://github.com/fabric8-ui/fabric8-planner/pull/2818 ).

centos-ci commented 5 years ago

@abhinandan13jan Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2822 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2822 and visit http://localhost:5000 to access it.

centos-ci commented 5 years ago

@abhinandan13jan Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2822 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2822 and visit http://localhost:5000 to access it.

abhinandan13jan commented 5 years ago

@sahil143 This PR is dependant on the other PR on tooltip ( https://github.com/fabric8-ui/fabric8-planner/pull/2818 ), which must be merged first. I see that the other PR is now merged. Can you check it again. The arrows are of type 'span' and 'span' doesn't have a disabled property so I've changed on the tooltip message part saying "Please select an attribute". Should I grey-out the spans as well using CSS?

sahil143 commented 5 years ago

Yes, You can disable using the css

abhinandan13jan commented 5 years ago

@sahil143 Added CSS

centos-ci commented 5 years ago

@abhinandan13jan Your image is available in the registry. Run docker pull quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2822 && docker run -it -p 5000:8080 quay.io/openshiftio/fabric8-ui-fabric8-planner:SNAPSHOT-PR-2822 and visit http://localhost:5000 to access it.

nimishamukherjee commented 5 years ago

@abhinandan13jan the behaviour works only for the first time. If I move the attributes back and forth, the arrows do not grey out. nexttime

abhinandan13jan commented 5 years ago

@joshuawilson ok

fabric8-ui / fabric8-planner

fix(table-config): Set arrows as disabled when no column is selected #2822

Mandatory