fabric8-ui / fabric8-ux

Design Links
https://uxd.fabric8.io/
Apache License 2.0
9 stars 9 forks source link

HTML/CSS: Fix work item empty state font #653

Closed catrobson closed 7 years ago

catrobson commented 7 years ago

The font for the first sentence in the empty state of the My Work Items box is a different font than the other empty state boxes show on the Account Homepage.

image

catrobson commented 7 years ago

Can we also change the text on the "recent active pipelines" widget empty state from "No recent failed or active pipelines" to "Pipelines reflect the integration and deployment stages your code will go through." and from "Failed pipelines or active pipelines will display here when you commit and build your codebase" to "Pipelines will display here when you commit and build your codebase."

junezhang commented 7 years ago

@catrobson please help to check the attachment. is it right?

screen shot 2017-09-07 at 4 46 33 pm

One concern about the capitalization.

  1. Create a Space is different with others. Should I update it to "Create a space"?
  2. The capitalize way is different with PatternFly. PatternFly suggests to capitalize the first letter of every word. for example: Recent Spaces, My Work Items, Recent Active Pipelines etc. the following is the PatternFly Headline Style Capitalize Guideline:

Headline style For headline style, capitalize the first letter of every word except for articles (a, an, the), coordinating conjunctions (and, but, or), and prepositions of three letters or fewer (of, on, by, in). There’s one exception: Any word that is the first word in the headline or the last word should be capitalized, regardless of its part of speech. For example, “Where to Install”

How do you think about it? Do you think i should update the capitalization in this page?

junezhang commented 7 years ago

@catrobson I've updated the capitalization like the below picture: screen shot 2017-09-08 at 4 26 16 pm Please help to review.

catrobson commented 7 years ago

@Essjaysee What do you think?

Essjaysee commented 7 years ago

Capitalization looks great, thanks! Just a couple other little things:

junezhang commented 7 years ago

The PR has been merged. so close this issue. if anything needs to update, please re-open it. https://github.com/fabric8-ui/fabric8-ui/pull/1988