Dev: Add 'Saved Filters' capability to Filter pattern in patternfly-ng

[catrobson]

We need to add saved filter capabilities, as specified by the design linked below, to patternfly-ng repo. We'll be contributing the design as a second step separate from this story.

Design: https://redhat.invisionapp.com/share/DUDF5ZA7J (Option 1)

Verification criteria:

• Capability added to filter pattern, PR reviewed and accepted by ng reviewers & Sunil, Samir

[dlabrecq]

I'm confused by the search bar in the filter menu. We recently added type ahead functionality, which basically does the same thing. Can we not use type ahead to prune the available custom filters?

[catrobson]

+1 the search bar should not be there - type-ahead handles this. This was agreed upon but the wireframes were not updated to reflect that discussion it looks like.

[dlabrecq]

There is also an issue with table views. That is, where the "save filter" control is located, we also display the number of selections. For example:

Would it be ok to move the "save filter" control next to "clear filters"?

[catrobson]

Just capturing here that we agreed we could put the save filter alongside "clear all filters"

[dlabrecq]

Should the "My Filters" option be visible when the user has not saved any filters? Or, after the user has removed all of their saved filters?

[muruGanesan]

IMO: we can 'gray out' (disabled state) when there is no data. - THIS CAN BE A COMMON BEHAVIOR for SUCH KIND OF CONTROLS. Option-1

Option-2

[muruGanesan]

@catrobson , sdash@redhat.com Please review my comments and provide your opinion

[dlabrecq]

I disabled the filter field as shown in option 1. The PR and demo can be found here: https://github.com/patternfly/patternfly-ng/pull/155

[dlabrecq]

Closing for the end of sprint 139-1. Please refer to the PR above.