fabric8-ui / fabric8-ux

Design Links
https://uxd.fabric8.io/
Apache License 2.0
9 stars 9 forks source link

Visual: List Row Colors #722

Closed AdamJ closed 6 years ago

AdamJ commented 6 years ago

In the design for the new User Settings area, the lists inside of each card have alternating colored rows (mimicking PatternFly’s table styling). Currently, PatternFly does not use alternating color rows for the List View - do we want to standardize on the new design, or keep in line with PatternFly?

AdamJ commented 6 years ago

Current visual design for User Settings: https://redhat.invisionapp.com/share/GHCW0C3P4

mceledonia commented 6 years ago

@mindreeper2420 In this case, since this isn't a fully-fledged list view, I think the alternating rows help a bit with readability and reinforce the idea that these are scrollable areas. I believe the color is #F5F5F5. The other option here would probably be light 1px divider lines.

What do you think @bdellasc?

AdamJ commented 6 years ago

My only concern is that we now have 3 different list views. There is a different list view in a card (on the Dashboards) that does not have the alternating rows, and then our main lists are not alternating rows. Isn't a list view a list view, no matter where it and and what it does?

mceledonia commented 6 years ago

That's a good point on having 3 different ones. I think the both of the card list-views should be the same, but I think the larger list views being different is ok since they take up more space and aren't as tightly packed in as the card list-views. I don't feel too strongly on that though so I could definitely be swayed either way.

catrobson commented 6 years ago

Did we make a decision about this the other day in the meeting @bdellasc @mceledonia?

bdellasc commented 6 years ago

I agree with @mceledonia RE: any lists on the cards having the same treatment, but that it seems alright for the large list view to be treated differently (strokes between rows, no BG colors).

Just thinking out loud:

Here is the design without alternating color rows: a-0200-userprofile_noaltcolorrows

Here is the current design: a-0200-userprofile_withaltcolorrows

That do you think?

Essjaysee commented 6 years ago

I will say that the tags (labels, whatever) are clearer and more obvious on the option with the row shading.

AdamJ commented 6 years ago

I prefer the option with the row shading when inside of a card. As Sj said, things are a lot more obvious with the row shading.

AdamJ commented 6 years ago

Should this move forward to update the lists inside of cards to be the alternating colors? This would be a nice item to add to the next sprint, if so.

catrobson commented 6 years ago

yes, I think we are all in agreement on that direction.