search

fabric8-ui / fabric8-ux

Design Links
https://uxd.fabric8.io/
Apache License 2.0
9 stars 9 forks source link

feat(upgrade): Upgrade PatternFly and clean site structure #779

Closed AdamJ closed 6 years ago

AdamJ commented 6 years ago

Update to PatternFly 3.31.0 with SASS in Core; clean site structure of duplicates

catrobson commented 6 years ago

391 files changed... what the heck Adam! :) Do you want a review of this in any meaningful way from Dan or someone?

AdamJ commented 6 years ago

@catrobson - the fun of changing the build structure to work with the new configuration :-) I just need someone to pull this down and run it, to make sure it works properly. The automated tests and builds passed, but another manual check never hurts.

catrobson commented 6 years ago

@dlabrecq Can you give this a shot when you have a moment?

dlabrecq commented 6 years ago

I downloaded the code and ran the site (seems ok), but not certain what I'm reviewing here? It appears that we're introducing PatternFly SASS, but I don't understand why?

AdamJ commented 6 years ago

Jekyll runs off of SASS, so I'm just converting the code that used patternfly-sass to the newest release of Core.

dlabrecq commented 6 years ago

Ah, yes. I recall you mentioning that now.