search

fabric8io-images / s2i

OpenShift S2I images for Java and Karaf applications
Apache License 2.0
70 stars 84 forks source link

AB_JOLOKIA_PORT customization probably isn't working, because it's hard-coded in the Dockerfile #116

Closed vorburger closed 5 years ago

vorburger commented 6 years ago

The README says:

AB_JOLOKIA_PORT : Port to use (Default: 8778)

but I doubt customizing this actually works - because while it's dynamic here, it's then hard-coded in the Dockerfile ...

rhuss commented 6 years ago

Yes, the expose doesn't make much sense that way. but as said elsedwhere EXPOSE is only meta data, we can skip it and still open the port.

rhuss commented 6 years ago

So we probably should just remove the EXPOSE line in the Dockerfile.

vorburger commented 6 years ago

as said elsedwhere EXPOSE is only meta data, we can skip it and still open the port. So we probably should just remove the EXPOSE line in the Dockerfile.

just FTR so that I can find this again, this is the discussion over in #115