search

fabric8io-images / s2i

OpenShift S2I images for Java and Karaf applications
Apache License 2.0
70 stars 84 forks source link

introduce javaMajor variable in template (#160) #187

Closed vorburger closed 5 years ago

vorburger commented 5 years ago

@rhuss this will let us switch 1.8.0 vs 11 ... OK for you?

vorburger commented 5 years ago

NB This extends #182, when reviewing this PR, just look at the 2nd commit 5104a0d0da0a71ffb5204a87b7c0596ecd21b237.

vorburger commented 5 years ago

@rhuss and any other active maintainer reading this, do you have any objections to merging this one?

rhuss commented 5 years ago

Sorry, I'm just at a f2f meeting with little to no spare time. So feel free to merge yourself, we can discuss this later still, too.

vorburger commented 5 years ago

TODO Following #182, I'll remove that commit from this PR when I rebase it.

vorburger commented 5 years ago

TODO Following #182, I'll remove that commit from this PR when I rebase it.

Done; @rhuss and other commiters, willing to review and merge this one?

rhuss commented 5 years ago

I'm afraid, there's no one left ;-) Gimme that evening, hopefully I can jump on it. If not, feel free to merge and I will do a review in retrospective.