search

fabric8io-images / s2i

OpenShift S2I images for Java and Karaf applications
Apache License 2.0
70 stars 84 forks source link

add Java 11 support (#160) #189

Closed vorburger closed 5 years ago

vorburger commented 5 years ago

@rhuss @gunnarmorling @ctron This last PR for today adds full Java 11 support!!!

It's based on a 5 other PRs which we can separately review and get in, first.

Or @rhuss you can just merge this... or I could? :smile:

rhuss commented 5 years ago

@vorburger cool, awesome ! I'm just at a conference, but I will give it a quick review tomorrow when I'm back so that we should get it merge still in this week.

vorburger commented 5 years ago

TODO @vorburger rebase this once the other PRs are merge, and remove fedora-java8 #182 here.

vorburger commented 5 years ago

rebase this once the other PRs are merge, and remove fedora-java8 #182 here.

Done. @rhuss re-review this now? I'll take the liberty to self merge this in 1 week if you don't get to it.

vorburger commented 5 years ago

Let me merge this as-is now (with verbal agreement from @rhuss), and then improve it iteratively.

Contributions from others who are interested in this very welcome! :smile: