Open vorburger opened 5 years ago
I don't think it's too surprising that run-java.sh still works, but some of the things it's doing (like calculating default memory settings) shouldn't be needed any more with Java 11.
Already created a PR for this: https://github.com/fabric8io-images/run-java-sh/pull/73 which is still not merged.
@rhuss not sure if there is anything left to do here? (Other than perhaps #213.)
Not sure either ;) I think if we have #213 done, we can close this issue, too.
With JDK-8146115 all of the size detection should be done automatically by the JVM. That includes JDK 8 (u191) and JDK 11. The relevant options are -Xlog:os+container=trace
for JDK 11 and -XX:+UnlockDiagnosticVMOptions -XX:+PrintContainerInfo
on JDK 8.
I cannot comment on other options those scripts use.
@jerboaa thanks for the feedback. Actually, we should update run-java.sh either to detect also whether a Java 8 JDK supports the cgroup awareness automatically (and switch off the homegrown calculation in this case), or add an extra flag/env var to indicate that this is not needed anymore. The latter is probably is simpler (and then could be reused here when we are using the proper base image), but we might strive for the former, too.
Regardless what, works needs to be done over there in ghttps://github.com/fabric8io-images/run-java-sh
@rhuss said in #160 that, quote:
But somewhat to my surprise, I seem to actually have been able to get a (basic) Java 11 working without touching run-java-sh ... I therefore propose that we work incrementally, and get #160 wrapped up and merged, and then iterate to improve things re. the point raised above under this issue.