Closed abkieling closed 5 years ago
@rhuss I wasn't able to use fish-pepper because it failed to install in my machine
@rhuss is this one good to go for you?
@alexkieling I don't suppose it would be possible to add a test.sh for this? Or I could merge it just trusting you...
@vorburger Do you mean adding a new test script or changing the existing one? We could hit the /metrics endpoint and look for labels with duplicated quotes.
@alexkieling adding something to the existing test.sh which would test for future non-regression of this problem (so it should fail without your fix and pass with it) could be very cool IMHO, if that's feasible. You probably saw how that script builds the container, runs it, and tests for a "hello, world" response from the example Server? If you could add something there to check that metrics are (a) present at all and (b) fix the problem that this is about, that would be really neat.
OK, I'll do that
@vorburger fish-pepper installation failed on Fedora 28: https://github.com/fabric8io-images/fish-pepper/issues/13 I'm currently unable to run test.sh
.
@vorburger test.sh
is currently testing the s2i-java-binary-example
image, which doesn't expose the Camel metrics I fixed.
@vorburger
test.sh
is currently testing thes2i-java-binary-example
image, which doesn't expose the Camel metrics I fixed.
Oh, I see; I hadn't even paid close enough attention to notice that this was Camel specific. Tell you what - let me finally merge this as is (thanks for your patience!). I've opened #200 to follow-up, if that's something you would be motivated to help this project with?
Fix #195