search

fabric8io-images / s2i

OpenShift S2I images for Java and Karaf applications
Apache License 2.0
70 stars 84 forks source link

JMX exporter: quoted property values captured incorrectly #195

Closed abkieling closed 5 years ago

abkieling commented 5 years ago

Object names with quoted property values are being incorrectly captured by regular expression defined in the JMX exporter configuration.

Current behavior The quotes and the value enclosed by the quotes are being captured.

Expected behavior Only the value enclosed by quotes should be captured.

Example of Prometheus metric after name object name property has been converted to processor label:

org_apache_camel_ExternalRedeliveries{context="MyCamel",processor="\"log1\"",type="processors",} 0.0

See file with more examples: metrics.txt

abkieling commented 5 years ago

PR https://github.com/fabric8io-images/s2i/pull/194 fixes this issue