search

fabric8io-images / s2i

OpenShift S2I images for Java and Karaf applications
Apache License 2.0
70 stars 84 forks source link

images/fedora/openjdk/11 instead of fedora-java11 etc. #196

Closed vorburger closed 5 years ago

vorburger commented 5 years ago

@rhuss has pointed out that instead of the "flat" images/fedora-java11 structure which #189 introduces for #160, we could in the future use FishPepper's "combinatorial multi-level" support to build e.g. images/fedora/openjdk/11/64bit/jdk (at the most extreme, or a suitable shortened version of this - depending on how much variability we ever anticipate).

The (non-S2I!) https://github.com/fabric8io-images/java project does this in its images.yml, note its 3 level params (base, version, type), the respective config and the related ignore-for in line 56.

rhuss commented 5 years ago

Agreed, that it makes much sense for maintaining (and that's exactly the purpose of fish-pepper to allow multiple, independent dimensions. Here: os=centos, rhel; version=8,11 plus maybe extra variants.

The question is, whether we want to have different image names as in https://github.com/fabric8io-images/java or doing everything under s2i-java with different tags (for the upstream images at least).

Wdyt ?

vorburger commented 5 years ago

The question is, whether we want to have different image names as in https://github.com/fabric8io-images/java or doing everything under s2i-java with different tags (for the upstream images at least).

I was thinking about that in #203 and decided to use tags. My main reason for going that way was "discoverability", know what I mean? The one (small) problem I found is that https://hub.docker.com/r/fabric8/s2i-java/ (from the README) is "wrong".

rhuss commented 5 years ago

wdym with "wrong" ? You mean the README on Docker Hub ? This is a file that has been manually added, and need to be edited on Docker Hub directly (as we are not using automated builds, but pushes the images via circleci).

Do you have karma on Docker hub for editing it ?

vorburger commented 5 years ago

wdym with "wrong" ? You mean the README on Docker Hub?

Just that https://hub.docker.com/r/fabric8/s2i-java/ says "with OpenJDK 8" which (now) is no longer entirely accurate.

This is a file that has been manually added, and need to be edited on Docker Hub directly

Oh! I just assumed that was https://github.com/fabric8io-images/s2i/blob/master/java/images/centos/README.md

Do you have karma on Docker hub for editing it ?

Don't think so, at least I don't see an Edit button. I'm https://hub.docker.com/u/vorburger/ over there, in case you want to somehow "invite" me, if that's possible.

But simplest is perhaps if you would like to just go ahead and edit it?

rhuss commented 5 years ago

Yes, let me do that. Updated https://hub.docker.com/r/fabric8/s2i-java/ now.