Closed michael-wirth closed 5 years ago
Would you be willing to add a non regression test for the problem which this fixes to the ./test.sh?
Would you be willing to add a non regression test for the problem which this fixes to the ./test.sh?
I added a test to check if all involved scripts/entrypoints correctly handle special command-line arguments
the test will fail until https://github.com/fabric8io-images/run-java-sh/pull/76 has been fixed and released as well
I've locally pulled this as-is and seen ./test.sh
fail, and then rebased it on top of #214 and seen it pass; therefore now merged (as 8fb67ed0ec52a2ffd5091f0a8d260e6a00774cdb & 11edaf05b47eddb047efb72a76d847486d8224c5) despite minor review feedback.
closes #211