fix: wrap args with quotes

fabric8io-images / s2i

OpenShift S2I images for Java and Karaf applications

Apache License 2.0

70 stars 84 forks source link

fix: wrap args with quotes #212

Closed michael-wirth closed 5 years ago

michael-wirth commented 5 years ago

closes #211

vorburger commented 5 years ago

Would you be willing to add a non regression test for the problem which this fixes to the ./test.sh?

michael-wirth commented 5 years ago

Would you be willing to add a non regression test for the problem which this fixes to the ./test.sh?

I added a test to check if all involved scripts/entrypoints correctly handle special command-line arguments

java -jar /deployments/app.jar -> works
/opt/run-java/run-java.sh -> fails
/usr/local/s2i/run -> fails

the test will fail until https://github.com/fabric8io-images/run-java-sh/pull/76 has been fixed and released as well

vorburger commented 5 years ago

I've locally pulled this as-is and seen ./test.sh fail, and then rebased it on top of #214 and seen it pass; therefore now merged (as 8fb67ed0ec52a2ffd5091f0a8d260e6a00774cdb & 11edaf05b47eddb047efb72a76d847486d8224c5) despite minor review feedback.