search

fabric8io-images / s2i

OpenShift S2I images for Java and Karaf applications
Apache License 2.0
70 stars 84 forks source link

220 useproductized jolokia fuse 7.x.redhat #221

Closed apupier closed 4 years ago

apupier commented 5 years ago

should we change also at these places?

https://github.com/fabric8io-images/s2i/blob/41cf3eaea0366580261b86ba67f24a0f6831f6c6/java/images/rhel/Dockerfile#L15

https://github.com/fabric8io-images/s2i/blob/41cf3eaea0366580261b86ba67f24a0f6831f6c6/java/images/rhel/Dockerfile#L61 Why is it retrieving with curl? should we do it also with curl but with the maven redhat repository and productized version?

vorburger commented 5 years ago

@apupier thanks for your interest and PR for this project. Full disclosure: I am maintaining the community version (master branch) of this project as a "hobby", and not in an official capacity. Before today I never looked at the fabric8io-images:fuse-7.x.redhat branch, and when I just did for the first time I noticed that (my) test.sh does not even pass on it... I thought to have understand from @rhuss some time last year that this is no longer used, but given your interest, it seems it is? I therefore have a suggestion / invitation for you - would you like to step up to become the maintainer of non-master productized branches? You would have my +1 vote to get commit privilege on those branches and do what you think needs to be done... I would ignore non-master PRs, and not mind at all if you "self-merged" on those branches. Are you interested in proceeding like that? PS: Just FYI note #218.

apupier commented 5 years ago

I thought to have understand from @rhuss some time last year that this is no longer used, but given your interest, it seems it is?

I was pointed to this repo when i asked what is used to create the Fuse images: https://access.redhat.com/containers/?tab=overview#/registry.access.redhat.com/fuse7/fuse-java-openshift

to have the merge with jboss-container-images/openjdk might be a very good idea. It might explain why VS Code OpenShift connector is working with https://access.redhat.com/containers/?tab=overview#/registry.access.redhat.com/redhat-openjdk-18/openjdk18-openshift and not with https://access.redhat.com/containers/?tab=overview#/registry.access.redhat.com/fuse7/fuse-java-openshift . it is why I landed here.

I therefore have a suggestion / invitation for you - would you like to step up to become the maintainer of non-master productized branches?

thanks for the proposition. For now, I don't feel that I know enough about these images to be responsible to merge modifications with my only point of view. Maybe after I sort out which images relies on which one and why and in which way they diverged.

vorburger commented 5 years ago

I therefore have a suggestion / invitation for you - would you like to step up to become the maintainer of non-master productized branches?

thanks for the proposition. For now, I don't feel that I know enough about these images to be responsible to merge modifications with my only point of view. Maybe after I sort out which images relies on which one and why and in which way they diverged.

OK. Hope you understand that I won't merge this PR. Perhaps other old committers on this project will. Up to you know if you want to keep this open or when you want to Abandon to Close it - or let me know if you are interested after all.

rhuss commented 5 years ago

@vorburger I see your point, but please note that we had from the very beginning a variant based on RHEL as a base image, which is used productized variations. So this repos supports both, plain community images but also RHEL based images. So I'm totally for merging this PR for RHEL images only.

vorburger commented 5 years ago

@rhuss I will not be able to help maintain the fuse-7.x.redhat branch on this project (only master).

apupier commented 4 years ago

closign as either things has moved from another side or still not moved and so there will be low probability that it happens oen day.