search

fabric8io-images / s2i

OpenShift S2I images for Java and Karaf applications
Apache License 2.0
70 stars 84 forks source link

removing duplicate ExchangesTotal #225

Open shawkins opened 5 years ago

jamesnetherton commented 5 years ago

I don't think they are duplicates as such. Camel exposes the ExchangesTotal metric for:

If you're only interested in the total exchanges for the lifetime of the application, you can query using the type label. E.g:

org_apache_camel_ExchangesTotal{type="context"}

shawkins commented 5 years ago

Yes, there are currently a total of 6 ExchangesTotal entries, two each for contexts, routes, and processors - which appear to be duplicates.

jamesnetherton commented 5 years ago

Can you show an example of this happening? E.g the output from:

curl -s localhost:9779/metrics | grep ExchangesTotal

shawkins commented 5 years ago

It does not create duplicate entries at runtime. No warning or errors are emitted from the agent. There are simply duplicate entries in the config, see the context duplicates:

https://github.com/fabric8io-images/s2i/blob/eab72be1b87ade2ab0c26fdecc52757fdf881531/java/images/rhel/prometheus-config.yml#L27

https://github.com/fabric8io-images/s2i/blob/eab72be1b87ade2ab0c26fdecc52757fdf881531/java/images/rhel/prometheus-config.yml#L34