ported ENTESB-10252: no_proxy in jvm argument not honoured in FIS Image

fabric8io-images / s2i

OpenShift S2I images for Java and Karaf applications

Apache License 2.0

70 stars 84 forks source link

ported ENTESB-10252: no_proxy in jvm argument not honoured in FIS Image #228

Closed valdar closed 5 years ago

valdar commented 5 years ago

original fix: https://github.com/fabric8io-images/s2i/commit/3390cc4d45831caf70f0becdb6383d8ccd7e5f12 more info: https://issues.jboss.org/browse/ENTESB-10252?focusedCommentId=13702157&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13702157

jamesnetherton commented 5 years ago

Looks ok....

I guess the bump to run-java v1.3.3 is why this change also pulls in a whole bunch of unrelated stuff? Like compatibility for JDKs > 8.

Wondering if it would be safer to create a redhat branch on the run-java project off of the v1.2.2 tag. Then we can reference that branch on fuse-7.x.redhat in this project and just consume minimal changes. I think we did a similar thing for FIS 2.0, guess we forgot to do it for Fuse 7.

WDYT?

valdar commented 5 years ago

I guess it is safer. Let's do that.

jamesnetherton commented 5 years ago

New branch here:

https://github.com/fabric8io-images/run-java-sh/tree/fuse-7.x.redhat