fabric8io-images / s2i

OpenShift S2I images for Java and Karaf applications
Apache License 2.0
70 stars 84 forks source link

[ENTESB-10728] MAVEN_MIRROR_URL does not work when settings.xml is present in configuration folder of the repo #236

Closed rnetuka closed 5 years ago

rnetuka commented 5 years ago

Issue: https://issues.jboss.org/browse/ENTESB-10728

Also fixes the same problem with HTTPPROXY variables.

rnetuka commented 5 years ago

@rhuss Hi. Unfortunatelly, I don't have working Node.js environment, so fish-pepper (nodegit dependency to be precise) gives me error when I try to run it. I' ve updated the files manually. Please verify. Thank you.

rhuss commented 5 years ago

You can easily run fish-pepper via Docker: docker run -it --rm -v $(pwd):/fp fabric8/fish-pepper

But I will check, however can't promise when.

rnetuka commented 5 years ago

@rhuss Thanks, I've run it with Docker and it looks good.

dhirajsb commented 5 years ago

LGTM