noCache property does nothing when set in pom

[vrevelas]

Description

I'm using a no-xml simple dockerfile build config and would like to disable the build cache.

Setting -Ddocker.noCache=true on the Maven command line works fine, but

<properties>
    <docker.noCache>true</docker.noCache>
</properties>

does nothing.

Based on the docs, I'm not sure if this is intended behaviour or not. For example, both docker.noCache and docker.name appear in the list of properties in table 29 here. Setting docker.name as a property in the pom works fine.

So I'm suggesting a fix would be to either

• make docker.noCache work when set as a property in pom.xml or
• update the docs to clearly show which properties work when set in pom.xml and which only work using -D on the maven command line.

Info

• d-m-p version : 0.33.0
• Maven version (mvn -v) :

  Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T17:29:23+00:00)
  Maven home: /opt/apache-maven
  Java version: 1.8.0_91, vendor: Oracle Corporation
  Java home: /usr/java/jdk1.8.0_91/jre
  Default locale: en_US, platform encoding: UTF-8
  OS name: "linux", version: "4.15.0-46-generic", arch: "amd64", family: "unix"

• Docker version : 18.06.1-ce
• If it's a bug, how to reproduce : Happy to provide a sample pom.xml if needed.
• If it's a feature request, what is your use case : NA
• Sample project : NA

[rhuss]

Look like a bug and indeed I would fix that the property is honoured, too. Happy to take any PR ! (I, unfortunately, can't invest much time in this project)

[Mikep86]

This issue has been open for a long time with no activity. Is there any update on a fix?

[rohanKanojia]

@Mikep86 : Sorry for the inconvenience. Would it be possible for you to find time to fix this and provide a PR?