search

fabric8io / docker-maven-plugin

Maven plugin for running and creating Docker images
https://dmp.fabric8.io
Apache License 2.0
1.88k stars 643 forks source link

Update maven-assembly-plugin version #1820

Open johanblumenberg opened 2 months ago

johanblumenberg commented 2 months ago

Description

There are newer versions of maven-assembly-plugin available.

The currently used version is maven-assembly-plugin:3.1.0, which has a compile dependency to maven-core:3.0, which means that maven-core:3.0 will be pulled down when you run the build.

maven-assembly-plugin:3.4.0 has changed this to be a provided dependency.

Updating the dependency to maven-assembly-plugin to version 3.4.0 or higher would avoid downloading maven-core:3.0 when building.

Info

rohanKanojia commented 2 months ago

@johanblumenberg : Thanks for reporting, Do you know if there are any breaking changes in 3.4.0 ?

johanblumenberg commented 2 months ago

@johanblumenberg : Thanks for reporting, Do you know if there are any breaking changes in 3.4.0 ?

There are some API changes that causes compile errors in docker-maven-plugin, but I did not dig any deeper into it.