fabric8io / fabric8-generator

a jboss forge add on for the fabric8 upstream and SaaS generator wizards
Apache License 2.0
1 stars 12 forks source link

allow users to keep their current Jenkinsfile on import #37

Open jstrachan opened 7 years ago

jstrachan commented 7 years ago

right now we override the Jenkinsfile with the chosen selection

joshuawilson commented 7 years ago

What happens when their current file changes how the build works and things break?

jstrachan commented 7 years ago

we replace the Jenkinsfile and use the new Jenkinsfile to run the first pipeline right now.

we've no idea if other Jenkinsfiles would even work inside kubernetes as a Jenkinsfile can do anything and be written for any kind of jenkins server / platform (e.g. doing native docker stuff or assuming old style jenkins slaves)

joshuawilson commented 7 years ago

That is what I thought, so why suggest keeping their Jenkinsfile?

jstrachan commented 7 years ago

Burr suggested we may want this as an option ;)

TBH I see this as pretty low priority really, as few folks will have effective Jenkinsfiles yet that work on OSO and do CI / CD properly - but some advanced user may wanna do their own Jenkinsfiles (at their own risk)

joshuawilson commented 7 years ago

thanks