new 'preserve jenkinsfiles' logic breaks quickstarts

fabric8io / fabric8-generator

a jboss forge add on for the fabric8 upstream and SaaS generator wizards

Apache License 2.0

1 stars 12 forks source link

new 'preserve jenkinsfiles' logic breaks quickstarts #60

Closed jstrachan closed 7 years ago

jstrachan commented 7 years ago

the new logic for imports unfortunately seems to break quickstarts now as they get created with the unusable RHOAR Jenkinsfiles instead which don't build/work on OSIO.

we should always replace the Jenkinsfiles when creating quickstarts as the RHOAR Jenkinsfiles are of negative value to OSIO (they don't work at all! :)

jstrachan commented 7 years ago

I guess we need some kinda flag to know if we are in the quickstart part of the wizard versus theimport part to know whether or not to overwrite by default

jstrachan commented 7 years ago

the new 'overwrite Jenksinfiles' checkbox doesn't appear for quickstarts; but we should still enable it by default though!

corinnekrych commented 7 years ago

@jstrachan I've just tested it on PROD:

here is the import flow: which ask for overrride then finish is successful
the quickstart flow with vertx: no checkbox asked successfully created.

Which flow is breaking? how to reproduce the issue?

jstrachan commented 7 years ago

what does the created Jenkinsfile look like? If its like this one then its using the Jenkinsfile from the quickstart - not from fabric8/OSIO - which don't work on OSIO