search

fabric8io / fabric8-generator

a jboss forge add on for the fabric8 upstream and SaaS generator wizards
Apache License 2.0
1 stars 12 forks source link

Use openshift-io email for creating GitHub repos #75

Closed alexeykazakov closed 7 years ago

alexeykazakov commented 7 years ago

See https://github.com/openshiftio/openshift.io/issues/777

alexeykazakov commented 7 years ago

@jstrachan @rawlingsj take a look please. It's unclear why the generator can't load even public emails but while we are investigating let's use openshift-io email.

jstrachan commented 7 years ago

LGTM

aslakknutsen commented 7 years ago

@corinnekrych It looks like only GHMyself.getEmail() is called. That will only fetch the email from the public profile if it's public. We do request user:email auth, and to get the private email we should call https://github.com/kohsuke/github-api/blob/master/src/main/java/org/kohsuke/github/GHMyself.java#L69 getEmails2() which calls the /user/emails endpoint.