search

fabric8io / fabric8-maven-plugin

📢 This project is migrated to 👉 https://github.com/eclipse/jkube
Apache License 2.0
334 stars 202 forks source link

OpenShift Templates #1

Open rhuss opened 8 years ago

rhuss commented 8 years ago

At the moment on plain Kubernetes objects are created. When running in OpenShift mode the template handling should be introduced.

In contrast to the old implementation where the template is created first and then, if pure Kubernetes objects are requested, the template is applied locally and objects from non-Kubernetes packages are removed, the discrimination template yes/no should be done from the very beginning.

Also it could make sense that even for OpenShift non-template can be created.

The idea is to have an OpenShiftConfiguration object, inherited from KubernetesKonfiguration and stored in a member openshift, so that the discrimnation happens based on the top-level configuration tag

<kubernetes>
  <services> ...
  ...
</kubernetes>

vs

<openshift>
  <useTemplates>true</useTemplates>

<openshift>

with useTemplates == true being the default. (useTemplates is then also only available for <openshift>

garethahealy commented 8 years ago

Has any work been done on this? looking in the source can't see any mentions of io.fabric8.openshift.api.model.TemplateBuilder, which i used with the v2 plugin

jstrachan commented 8 years ago

FWIW gofabric8 installs things as kubernetes templates.

We could have a plugin configuration to force the openshift.yml to be converted to an OpenShift template. I guess it depends if openshift users ever choose to go with helm which supports install, upgrade & delete - rather than just install

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

rohanKanojia commented 5 years ago

You're such a pain,stalebot