search

fabric8io / fabric8

fabric8 is an open source microservices platform based on Docker, Kubernetes and Jenkins
http://fabric8.io/
1.76k stars 504 forks source link

can we disable features:install if a fabric has been created? Or maybe add a different implementation or something? #2365

Closed jstrachan closed 10 years ago

jstrachan commented 10 years ago

as features:install shouldn't be used when inside a fabric

davsclaus commented 10 years ago

it used to work where you get a warning about its not possible, and you needed to use profile:edit to assign features.

davsclaus commented 10 years ago

Yeah its not doing that check anymore.

@iocanel can you remember what we did to prevent users from changing the fabric containers? Do we have some special code in karaf?

eg I just did

bin/fabric8

Fabric8:karaf@root> features:install camel-http
Refreshing bundles org.apache.servicemix.bundles.jaxb-impl (116), org.apache.camel.camel-core (162)
Fabric8:karaf@root> features:install camel-twitter
Fabric8:karaf@root>
[ 200] [Active     ] [            ] [   50] camel-http (2.13.2)
[ 201] [Active     ] [Created     ] [   30] Apache Karaf :: Features :: Management (2.4.0.redhat-620004)
[ 202] [Active     ] [            ] [   50] Apache ServiceMix :: Bundles :: twitter4j (3.0.5.1)
[ 203] [Active     ] [            ] [   50] camel-twitter (2.13.2)
davsclaus commented 10 years ago

We need this fixed before the 1.2 release

iocanel commented 10 years ago

Just a matter of sorting out the service ranking on the fabric impl of feature service.