Open paoloantinori opened 9 years ago
+1 we would like to have java code for the unzip/untar and any file modification works to set file permissions, delete dirs etc. so it works on all platforms. Today windows is not supported.
Also all those file search/replace and whatnot the SSH create container does would be nice if it was just java code too.
At least one of the 'sed' invocation quietly fails during the provisioning of a remote ssh container on Linux. It can be seen setting log levels before the container creation:
This is the error:
The file that needs adjustment is probably this:
https://github.com/fabric8io/fabric8/blob/master/fabric/fabric-core/src/main/resources/io/fabric8/internal/replace_property_value.sh
I think it has to do with escaping, with the fact that we are using
/
as a separator.I'd like to point to the fact that Linux
sed
and MacOSXsed
are not completely compatible, I have seen it myself in the past.This is a discussion around the topic but there are multiple: http://unix.stackexchange.com/questions/13711/differences-between-sed-on-mac-osx-and-other-standard-sed
I wonder if it could make sense doing the extra effort to move completely away from native commands, eventually using some layer that could still be expressed with the same structure, like using this lib:
https://code.google.com/p/unix4j/