search

fabric8io / fabric8

fabric8 is an open source microservices platform based on Docker, Kubernetes and Jenkins
http://fabric8.io/
1.76k stars 504 forks source link

need to be able to configure fabric8:deploy to work behind a proxy #2972

Open christian-posta opened 10 years ago

christian-posta commented 10 years ago

right now fabric8:deploy uses jolokia client to make the connection to the remote fabric. however, jolokia client uses the DefaultHttpClient under the covers and doesn't really expose a good way to configure for a proxy that may be in the way.

Either I'm missing something, and we can do this, or we should patch jolokia (I'll open an issue) and have them use SystemDefaultHttpClient so that we can set JVM system variables (e.g., http.proxyHost, http.proxyPort) and have those picked up automatically.

http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/client/SystemDefaultHttpClient.html

Related to the jolokia issue here: https://github.com/rhuss/jolokia/issues/169

davsclaus commented 9 years ago

@christian-posta is this about fabric v1?

Here today in v2 we use http client (not jolokia) https://github.com/fabric8io/fabric8/blob/master/fabric8-maven-plugin/src/main/java/io/fabric8/maven/support/Apps.java#L47

But that code seems not supporting any http proxy options either.

I am not sure if apache http client support those jvm http proxy settings out of the box, which it may do. But we could also allow to configure this in the pom.xml so end user can set this explicit.