fabric8io / fabric8

fabric8 is an open source microservices platform based on Docker, Kubernetes and Jenkins
http://fabric8.io/
1.77k stars 505 forks source link

[release] no way to find out if github pull request failed checks #4943

Closed rawlingsj closed 8 years ago

rawlingsj commented 8 years ago

Currently we send hubot notifications when the PR mergeable_state is unstable, however this is the status when the CI job first starts and not when its failed. There doesnt seem to be anything on the github api to figure out when checks failed so we might have to figure out the jenkins CI job and watch that instead Until then we will send a notification with the details of how to clone the pull request and fix if checks fail.

Example PR

curl https://api.github.com/repos/fabric8io/ipaas-quickstarts/pulls/797

rawlingsj commented 8 years ago

we should use the head commit status of the pull request rather than the status if the pr itself https://developer.github.com/v3/repos/statuses/ - thanks @jimmidyson