fabric8io / fluent-plugin-kubernetes_metadata_filter

Enrich your fluentd events with Kubernetes metadata
Apache License 2.0
351 stars 166 forks source link

fix #263: use filter in lieu of filter_stream as recommended optimization #276

Closed jcantrill closed 2 years ago

jcantrill commented 3 years ago

fix #263: use filter in lieu of filter_stream as recommended optimiza

jcantrill commented 3 years ago

cc @ewolinetz @alanconway @vimalk78 are takers for review?

jcantrill commented 3 years ago

The change looks OK, but I dont' see the changes to callers of filter_stream

@alanconway I believe the callers are unknown to most users as it handled internally by fluentd when you define use of the plugin via configuration. It is fluentd that makes the optimization.

alanconway commented 3 years ago

/lgtm