fix #257. Add warning log when 'K8S_NODE_NAME' is not set

fabric8io / fluent-plugin-kubernetes_metadata_filter

Enrich your fluentd events with Kubernetes metadata

Apache License 2.0

351 stars 166 forks source link

fix #257. Add warning log when 'K8S_NODE_NAME' is not set #284

Closed jcantrill closed 3 years ago

jcantrill commented 3 years ago

This PR:

fixes #257 by issuing a warning message when the node name is not set
warning chosen over requirement to address backwards compatibility

cc @alanconway

jcantrill commented 3 years ago

@alanconway the functionality already exists within this plugin to watch pods and restrict that watch to a given node. That restriction is passed in by setting K8S_NODE_NAME. This means the number of pods will be very small. The original ask was to make the variable required but I don't think that will guarantee backwards compatibility. This change will warn the user that its not efficient.