chore(gems): peg kubeclient to >= 4.0.0

fabric8io / fluent-plugin-kubernetes_metadata_filter

Enrich your fluentd events with Kubernetes metadata

Apache License 2.0

351 stars 166 forks source link

chore(gems): peg kubeclient to >= 4.0.0 #295

Closed Cryptophobia closed 3 years ago

Cryptophobia commented 3 years ago

peg kubeclient gem to 4.x.x versions

Signed-off-by: Anton Ouzounov aouzounov@vmware.com

Recently had a problem where bundle install chose to install gem version 1.0.0 for kubeclient gem. I am not exactly sure what exactly caused this but I know that fluent-plugin-kubernetes_metadata_filter is the only gem that requires kubeclient when reversing the gem dependencies. But I believe that this small change may solve it.

Cryptophobia commented 3 years ago

@jcantrill , had a weird dependency error where bundler installed kubeclient (1.0.0) instead of the latest kubeclient (4.9.2). I think if we define stricter versioning in the .gemspec file when pulling the gem from Rubygems, it should force bundler to use a later version of kubeclient.

cben commented 3 years ago

Makes sense :+1:, kubeclient had some breaking changes between major releases (we try to follow semver there), so allowing more than one major version is risky.

Cryptophobia commented 3 years ago

@jcantrill , any ideas if anything else needs to be done for this PR to merge? Any particular testing that we would want to perform?

Looks at the Gemfile.lock that the plugin is already pulling 4.9.2 . It is just that in my particular case it was pulling a older client.

jcantrill commented 3 years ago

Closing in favor of https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter/pull/304

Cryptophobia commented 3 years ago

Thank you @jcantrill ! I can delete my fork now. :)