Allow use of fluentd v1.17.0

fabric8io / fluent-plugin-kubernetes_metadata_filter

Enrich your fluentd events with Kubernetes metadata

Apache License 2.0

350 stars 166 forks source link

Allow use of fluentd v1.17.0 #382

Closed kenhys closed 2 months ago

kenhys commented 3 months ago

$ bundle update fluentd

https://github.com/fluent/fluentd/releases/tag/v1.17.0

jcantrill commented 3 months ago

@kenhys are you able to confirm unit tests run without error possibly with several versions of ruby (ie. 2.7, 3.1)? I see failures here https://app.circleci.com/pipelines/github/fabric8io/fluent-plugin-kubernetes_metadata_filter but I have not seen CI in a while so not certain what needs to maybe change

kenhys commented 3 months ago

Since fluentd v1.17.0, the minimum requirement ruby version is raised to 2.7, so ruby-test-1 can't be satisfied anymore.

kenhys commented 3 months ago

It may be better to add ruby 3.2 and 3.3 too, but it is out of scope.

kenhys commented 3 months ago

Now passed.

kenhys commented 3 months ago

I've tried to replace with cimg/ruby.

https://app.circleci.com/pipelines/github/fabric8io/fluent-plugin-kubernetes_metadata_filter/347/workflows/d92d829f-c27b-4dd7-9ee2-643126870e14/jobs/1185

but it fails unexpectedly. it is strange that cimg/ruby seems based on focal, but error log indicates debian/buster :thinking:

kenhys commented 3 months ago

Surely it is focal...

docker run --rm -it cimg/ruby:2.7.8 /bin/bash
circleci@a22385b37a04:~/project$ ruby -v
ruby 2.7.8p225 (2023-03-30 revision 1f4d455848) [x86_64-linux]
circleci@a22385b37a04:~/project$ lsb_release -c
Codename:   focal

kenhys commented 3 months ago

got it. missingdeps: use it.

kenhys commented 3 months ago

circleci test with cimg/ruby has passed.