fabric8io / gofabric8

CLI used when working with fabric8 running on Kubernetes or OpenShift
https://fabric8.io/
Apache License 2.0
147 stars 72 forks source link

`gofabric8 version` command prints error #594

Closed ilovezfs closed 7 years ago

ilovezfs commented 7 years ago

The problem occurs with 0.4.161. It does not affect 0.4.157.

The Homebrew test block fails because the version command no longer seems to work:

With 0.4.161:

$ gofabric8 version
Could not initialise a client - is your server setting correct?

Get http://localhost:8080/api: dial tcp [::1]:8080: getsockopt: connection refusedbash-3.2$ 

With 0.4.157:

$ gofabric8 version
A newer version of gofabric8 is available. Do you want to
automatically update from v0.4.157 to v0.4.161 now? [y/N] N
Skipping auto-update.
gofabric8, version 0.4.157 (branch: 'unknown', revision: 'homebrew')
  build date:       '20170920-01:13:13'
  go version:       '1.9'
ilovezfs commented 7 years ago

This is still a problem in 0.4.162.

hydra1983 commented 7 years ago

This is still a problem in 0.4.163

seems 0.4.159 is the last working version Mac 10.11.6

ilovezfs commented 7 years ago

@jstrachan any idea what the problem here is? This is still an issue as of 0.4.171.

rawlingsj commented 7 years ago

I ran into this, this morning. I trashed my vms and tried to run gofabric8 start ... and got the error, gofabric8 version and gofabric8 help all affected.

I had to manually start minishift minishift start --vm-driver=xhyve --memory=6096 --cpus=5 and run gofabric8 deploy --package system -y -n fabric8

So I yeah it looks like something changed between 0.4.157 and 0.4.161.

I'll take a look.

ilovezfs commented 7 years ago

Thanks @rawlingsj! That would be great.

rawlingsj commented 7 years ago

Good old git bisect! Found the issue and it's something I added :) fixing now.. sorry for the wait!

rawlingsj commented 7 years ago

Issue is this commit https://github.com/fabric8io/gofabric8/commit/f06ea28d8ec8b37037e063eafac8098dea538cd0

ilovezfs commented 7 years ago

No worries @rawlingsj! Thanks again :)

rawlingsj commented 7 years ago

No problem at all @ilovezfs! Just kicked off a release so 0.4.173 should be available in ~15 mins.

ilovezfs commented 7 years ago

@rawlingsj Voilà: https://github.com/Homebrew/homebrew-core/pull/19602.

rawlingsj commented 7 years ago

@ilovezfs yay!!

ilovezfs commented 7 years ago

Shipped!

rawlingsj commented 7 years ago

Awesome! Thanks @ilovezfs

ilovezfs commented 7 years ago

You're welcome :)