search

fabric8io / kubeflix

Kubernetes integration with Netflix OSS
266 stars 69 forks source link

NullPointerException while getting list of services has been fixed. #185

Open irbis opened 7 years ago

irbis commented 7 years ago

By default KubernetesServerList() initializes with default constructor and then method initWithNiwsConfig(IClientConfig clientConfig) runs.

Default constructor doesn't initialize this.client that leads to NullPointerException in line 67. This has been fixed.

Also, hellohystrix and helloribbon use different keys and looks like this is a reason why ribbon can't find hello-hystrix command.

cc: @iocanel

irbis commented 7 years ago

Hi @iocanel Is this pull request is usefull?

Thanks,

sonata82 commented 7 years ago

Shouldn't client be initialized in the default empty constructor then?

And I'm not sure, but it the default constructor used anyway?

irbis commented 7 years ago

It in use. And this leads to NullPointerException.