Cachelock

[shawkins]

Description

Fixes #5973

Replaces #5699 as there have been no updates there in a while. Tweaks the previous pr to address the concerns mentioned in the review and to limit global locking to only methods that mutate the indexes / index functions.

Also some minor refactoring to make the CacheImpl logic a little more streamlined.

Type of change

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] Feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change
• [ ] Chore (non-breaking change which doesn't affect codebase; test, version modification, documentation, etc.)

Checklist

• [x] Code contributed by me aligns with current project license: Apache 2.0
• [x] I Added CHANGELOG entry regarding this change
• [x] I have implemented unit tests to cover my changes
• [ ] I have added/updated the javadocs and other documentation accordingly
• [ ] No new bugs, code smells, etc. in SonarCloud report
• [ ] I tested my code in Kubernetes
• [ ] I tested my code in OpenShift

[manusa]

For some reason, there are tests failing. However, none of the modified production code seems to be related to these failures.

[shawkins]

For some reason, there are tests failing. However, none of the modified production code seems to be related to these failures.

There was a subtle change that indexes used to allow null keys before, and now they don't with this code - I hadn't fully paid attention to a null check that was added in the previous pr. It seems like we should preserve that behavior, so I'll make an update.

[shawkins]

@manusa this looks better, but still hit some test flakiness.

[shawkins]

@manusa should be good now. That test really wasn't of much use, so it's been removed. I did preserve the use of the concurrenthashmap for the index, but didn't see it made much difference of a synchronized map as we're never doing any iteration.

[sonarcloud[bot]]

Quality Gate failed

Failed conditions
60.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud