search

fabric8io / kubernetes-client

Java client for Kubernetes & OpenShift
http://fabric8.io
Apache License 2.0
3.41k stars 1.46k forks source link

Change value of @Generated annotation #6514

Open manusa opened 1 week ago

manusa commented 1 week ago

Description

Part of #6130

Replace value of @Generated("jsonschema2pojo") annotation. The current value was set for compatibility with the current generator and to avoid having code differences here (help validation of new generator).

The value should be replaced now to @Generated("io.fabric8.kubernetes.schema.generator.model.ModelGenerator"). This can be easily accomplished by modifying the value here:

https://github.com/fabric8io/kubernetes-client/blob/641b2c874cea4531cd8382910f317832800a7122/kubernetes-model-generator/openapi/maven-plugin/src/main/resources/templates/model_class_annotations.mustache#L77

vaidikcode commented 1 week ago

@manusa I updated the @Generated("jsonschema2pojo") annotation to @Generated("io.fabric8.kubernetes.schema.generator.model.ModelGenerator") as outlined in the steps. However, the build failed after making the change.

manusa commented 4 days ago

This need to wait until all model generation has been refactored to use OpenAPI (currently 5 extensions are yet to be completed).

In order to complete the issue, the value needs to be changed for the template. Then, the models need to be regenerated: make openapi-generate-java-classes. For each of those steps, a separate commit would be appropriate to ease reviewing process.