search

fabric8io / mockwebserver

An extension of okhttp's mockwebserver, that provides a DSL and is easier to use
Apache License 2.0
113 stars 38 forks source link

Re-release mockwebserver with the updated okhttp dependency #27

Closed LesterTheTester closed 4 years ago

LesterTheTester commented 5 years ago

Dependency on OKHTTP was updated to 3.10.0, but no new version has been released. For projects that are using 3.10.0 elsewhere, there is a breaking change from 3.9.1...the method signature of RealWebSocket in OKHTTP mockwebserver has changed, so you'll get

java.lang.NoSuchMethodError: No direct method (Lokhttp3/Request;Lokhttp3/WebSocketListener;Ljava/util/Random;)V in class Lokhttp3/internal/ws/RealWebSocket; or its super classes

Can we please re-roll a new version with okhttp 3.10 so we don't have to mess with our transitive gradle dependencies? Thank you.

LesterTheTester commented 5 years ago

It also seems that there's some bugs around the implementation change of websockets in mockwebserver, which leads to queued messages all being dispatched at once. I may look into it, but it seems like this project might be abandoned and I might be better off using MWS directly.

rohanKanojia commented 5 years ago

@LesterTheTester : Hi, We're facing this error in fabric8 kubernetes client after upgrading okhttp to 3.12. Do you have any code pointer where this is happening?

rohanKanojia commented 5 years ago

I think we should proceed with releasing 0.1.1 once #31 gets merged

rohanKanojia commented 5 years ago

mockwebserver 0.1.1 has been released with okhttp 3.12.1. I think we can close this