kubernetes-client_iss_1688 - Added type(with or without) in Attribute

fabric8io / mockwebserver

An extension of okhttp's mockwebserver, that provides a DSL and is easier to use

Apache License 2.0

113 stars 38 forks source link

Closed jorgesartori closed 4 years ago

jorgesartori commented 4 years ago

Added type(with or without) in Attribute allow without filter in extractor (key != value).

rohanKanojia commented 4 years ago

@jorgesartori : A test seems to be failing, could you please take a look here?

jorgesartori commented 4 years ago

Here it works... I did run in master branch (without changes) and result is the same:

jorgesartori commented 4 years ago

How can I get circleci permissions to run again?

rohanKanojia commented 4 years ago

let me try if I can do it.

jorgesartori commented 4 years ago

"Could you please address these minor comments whenever you get time?" I didn't find changelog, where I do this?

rohanKanojia commented 4 years ago

looks like there is no changelog. Could you please add one?

jorgesartori commented 4 years ago

done ;)