fabric8io / openshift-elasticsearch-plugin

Apache License 2.0
27 stars 21 forks source link

bug 1490719. Operations missing from .all alias #102

Closed jcantrill closed 7 years ago

jcantrill commented 7 years ago

This PR fixes the issue where .operations is missing from the .all alias

Test before fix:

#encoding: utf-8
Feature: The openshift-elasticsearch-plugin initializes access
  control to indices in the cluster and Kibana UI objects

  @kibana @test
  Scenario: The .all alias references all indices                 # features/openshift-elasticsearch-plugin.feature:27
    Given a user with the role of operations                      # features/step_definitions/policy_steps.rb:1
    And the .all alias initially does not exist                   # features/step_definitions/elasticsearch_steps.rb:7
    And logs were collected for the logging project               # features/step_definitions/elasticsearch_steps.rb:1
    When they log into Kibana                                     # features/step_definitions/kibana_steps.rb:1
    Then the .all alias should alias indices: operations, logging # features/step_definitions/elasticsearch_steps.rb:13
      Exp. the .all to include: ["logging", "operations"] but it only references ["logging"] (RuntimeError)
      ./features/step_definitions/elasticsearch_steps.rb:22:in `/^the (.*) alias should alias indices: (.*)$/'
      ./features/support/hooks.rb:14:in `block in <top (required)>'
      features/openshift-elasticsearch-plugin.feature:33:in `Then the .all alias should alias indices: operations, logging'

Failing Scenarios:
cucumber features/openshift-elasticsearch-plugin.feature:27 # Scenario: The .all alias references all indices

1 scenario (1 failed)
5 steps (1 failed, 4 passed)
0m9.944s

After:

Feature: The openshift-elasticsearch-plugin initializes access
  control to indices in the cluster and Kibana UI objects

  @kibana @test
  Scenario: The .all alias references all indices                 # features/openshift-elasticsearch-plugin.feature:27
    Given a user with the role of operations                      # features/step_definitions/policy_steps.rb:1
    And the .all alias initially does not exist                   # features/step_definitions/elasticsearch_steps.rb:7
    And logs were collected for the logging project               # features/step_definitions/elasticsearch_steps.rb:1
    When they log into Kibana                                     # features/step_definitions/kibana_steps.rb:1
    Then the .all alias should alias indices: operations, logging # features/step_definitions/elasticsearch_steps.rb:13

1 scenario (1 passed)
5 steps (5 passed)
0m13.045s