search

fabric8io / openshift-elasticsearch-plugin

Apache License 2.0
27 stars 21 forks source link

fix #155. Fix permissions for KibanaIndexMode #156

Closed jcantrill closed 6 years ago

jcantrill commented 6 years ago

This PR fixes #155 and will most likely need additional changes in sg_action_groups for permissions

Also fixes #117

jcantrill commented 6 years ago

@ewolinetz @richm Please when looking at these changes consider looking at files like which is my expectation of what the perm file(s) should be according to how we define KibanaIndexMode.

[1] https://github.com/fabric8io/openshift-elasticsearch-plugin/blob/2abc1531a05dd5e067d4b57f8ced4dca164a5192/src/test/resources/io/fabric8/elasticsearch/plugin/project_strategy_roles_shared_non_ops_kibana_mode.yml

jcantrill commented 6 years ago

@richm @ewolinetz Updated per CR

jcantrill commented 6 years ago

@richm @ewolinetz I've updated the code to match the KibanaIndexMode as advertised as well as fix to pass https://github.com/openshift/origin-aggregated-logging/pull/1273.

NOTE: Added several integration tests to match those we have in the logging repo.

richm commented 6 years ago

openshift/origin-aggregated-logging#1273 passed so I'm assuming this PR is good to go /lgtm

jcantrill commented 6 years ago

[merge]