search

fabric8io / openshift-elasticsearch-plugin

Apache License 2.0
27 stars 21 forks source link

enhancement #LOG192. Impl Openshift Token Auth #158

Closed jcantrill closed 5 years ago

jcantrill commented 5 years ago

Enhancement to add bearer token auth https://jira.coreos.com/browse/LOG-192

This PR additionally allows us to add static groups which should also satisfy the prometheus metrics usecase and removing the proxy for that use.

ewolinetz commented 5 years ago

Would this PR also let us remove the oauth proxy container?

Edit: Answered by https://github.com/openshift/origin-aggregated-logging/pull/1363

jcantrill commented 5 years ago

@ewolinetz I went ahead and removed the 'enabled' configs.

ewolinetz commented 5 years ago

@jcantrill can you add to the README that we removed the flags to enable and disable functionality? Otherwise lgtm

ewolinetz commented 5 years ago

/hold

ewolinetz commented 5 years ago

i dont think the bot is listening here...

richm commented 5 years ago

yeah - I think Jeff will merge it manually if we approve - so just Request Changes for now

jcantrill commented 5 years ago

Merging as https://github.com/openshift/origin-aggregated-logging/pull/1363 finally passed its tests