Fix delete index pattern v2

fabric8io / openshift-elasticsearch-plugin

Apache License 2.0

27 stars 21 forks source link

Fix delete index pattern v2 #159

Closed jcantrill closed 5 years ago

jcantrill commented 5 years ago

The PR:

fixes #135
Moves response rewrite for Kibana index to the rest level

Notes:

It wasn't readily obvious to me the plugin would creating the index-pattern we deleted if it was one that we seed on request
If the response includes Kibana indices they will be reset to the default. I'm fairly certain this is not a regression but the behavior we saw prior
need to rebase on #158

ewolinetz commented 5 years ago

Do we have tests for this? I'd like to make sure that it can still correctly return the different types of responses to Kibana without it breaking due to us tampering with the query/response.

jcantrill commented 5 years ago

@ewolinetz added tests. GetFieldMappings was not possible as it has no public constructor

jcantrill commented 5 years ago

[merge]