search

fabric8io / openshift-elasticsearch-plugin

Apache License 2.0
27 stars 21 forks source link

Addressing scoped token issue when checking for cluster-admin #32

Closed ewolinetz closed 8 years ago

ewolinetz commented 8 years ago

@jcantrill @jimmidyson PTAL We can't merge this in to master it seems... (which is currently tracking for ES 2.3) and this fix applies to ES 1.5

Thoughts on how we can release this? It is to resolve https://bugzilla.redhat.com/show_bug.cgi?id=1369824

jcantrill commented 8 years ago

Don't we have available versions from 0.18 or something up to 4.x. We can branch before our upgrade changes and then merge and release from the branch. @jimmidyson might need to provide input on how we actually get it into maven

On Wednesday, August 24, 2016, Eric Wolinetz notifications@github.com wrote:

@jcantrill https://github.com/jcantrill @jimmidyson https://github.com/jimmidyson PTAL We can't merge this in to master it seems... (which is currently tracking for ES 2.3) and this fix applies to ES 1.5

Thoughts on how we can release this? It is to resolve

https://bugzilla.redhat.com/show_bug.cgi?id=1369824

You can view, comment on, or merge this pull request online at:

https://github.com/fabric8io/openshift-elasticsearch-plugin/pull/32 Commit Summary

  • Addressing scoped token issue when checking for cluster-admin

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fabric8io/openshift-elasticsearch-plugin/pull/32, or mute the thread https://github.com/notifications/unsubscribe-auth/AEVnOE4IJwRxCc4WKfNhjfnTBJ8jmn5yks5qjKJYgaJpZM4JsZDQ .

Jeff Cantrill Senior Software Engineer, Red Hat Engineering OpenShift Integration Services Red Hat, Inc. Office: 703-748-4420 | 866-546-8970 ext. 8162420 jcantril@redhat.com http://www.redhat.com

ewolinetz commented 8 years ago

@jcantrill I'm not following... we've already merged the ES 2.3 changes for this plugin into master. The bz impacts es 1.5, so we would need to somehow release this change so it is available for our master branch in aggregated logging. I branched this from the commit for the v0.14 release, however we only merge into master currently and differentiate with versions.

ewolinetz commented 8 years ago

closing pr to reopen against es1.5 branch